Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support to read tinyint #22

Merged
merged 3 commits into from
Nov 5, 2023
Merged

feat: support to read tinyint #22

merged 3 commits into from
Nov 5, 2023

Conversation

WenyXu
Copy link
Collaborator

@WenyXu WenyXu commented Nov 4, 2023 •
edited
Loading

Support to read tinyint data

close #17

@WenyXu WenyXu requested a review from Jefffrey November 4, 2023 14:05
@codecov Codecov
Copy link

codecov bot commented Nov 4, 2023 •
edited
Loading

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (47bb450) 73.75% compared to head (995e0f3) 79.35%.
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   73.75%   79.35%   +5.60%     
==========================================
  Files          27       29       +2     
  Lines        2343     2499     +156     
==========================================
+ Hits         1728     1983     +255     
+ Misses        615      516      -99
Flag Coverage Δ
rust 79.35% <96.41%> (+5.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/arrow_reader/column.rs 92.96% <100.00%> (ø)
src/arrow_reader/column/date.rs 92.30% <100.00%> (+0.64%) ⬆️
src/arrow_reader/column/tinyint.rs 100.00% <100.00%> (ø)
src/async_arrow_reader.rs 79.83% <100.00%> (+0.52%) ⬆️
src/error.rs 0.00% <ø> (ø)
src/reader/metadata.rs 97.29% <100.00%> (+0.23%) ⬆️
src/arrow_reader.rs 85.46% <87.50%> (+6.47%) ⬆️
src/reader/decompress.rs 94.04% <97.33%> (+13.37%) ⬆️
src/reader/decode/byte_rle.rs 94.80% <94.80%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Jefffrey
Jefffrey reviewed Nov 4, 2023
View reviewed changes
Copy link
Collaborator

@Jefffrey Jefffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think TinyInt should map to i8 and not u8

Can see Arrow cpp reference here maps it to Int8 datatype:

https://arrow.apache.org/docs/cpp/orc.html

Jefffrey
Jefffrey reviewed Nov 5, 2023
View reviewed changes
src/reader/decode/byte_rle.rs Outdated Show resolved Hide resolved
src/reader/decode/byte_rle.rs Outdated Show resolved Hide resolved
@WenyXu
Copy link
Collaborator Author

WenyXu commented Nov 5, 2023

@Jefffrey I mapped it to i8, PTAL

Jefffrey
Jefffrey approved these changes Nov 5, 2023
View reviewed changes
Copy link
Collaborator

@Jefffrey Jefffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good

@WenyXu WenyXu merged commit f158593 into datafusion-contrib:main Nov 5, 2023
8 checks passed
@waynexia waynexia mentioned this pull request Oct 30, 2024
Open
16 tasks
waynexia pushed a commit that referenced this pull request Oct 24, 2024
@WenyXu
Merge pull request #22 from WenyXu/feat/support-tiny-int
e1af701 
feat: support to read tinyint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jefffrey Jefffrey Jefffrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tinyint support
2 participants
@WenyXu @Jefffrey